thetumbled commented on code in PR #21030:
URL: https://github.com/apache/pulsar/pull/21030#discussion_r1300830266


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -84,6 +86,8 @@ public class SystemTopicBasedTopicPoliciesService implements 
TopicPoliciesServic
     @VisibleForTesting
     final Map<TopicName, List<TopicPolicyListener<TopicPolicies>>> listeners = 
new ConcurrentHashMap<>();
 
+    final Map<TopicName, BlockingDeque<CompletableFuture>> results = new 
ConcurrentHashMap<>();

Review Comment:
   All request for setting topic policy will redirect to the owner broker of 
the partition-0, so we do not need to consider distributed situations.



##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/SystemTopicBasedTopicPoliciesService.java:
##########
@@ -84,6 +86,8 @@ public class SystemTopicBasedTopicPoliciesService implements 
TopicPoliciesServic
     @VisibleForTesting
     final Map<TopicName, List<TopicPolicyListener<TopicPolicies>>> listeners = 
new ConcurrentHashMap<>();
 
+    final Map<TopicName, BlockingDeque<CompletableFuture>> results = new 
ConcurrentHashMap<>();

Review Comment:
   All request for setting topic policy will be redirected to the owner broker 
of the partition-0, so we do not need to consider distributed situations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to