RobertIndie commented on code in PR #167:
URL: https://github.com/apache/pulsar-dotpulsar/pull/167#discussion_r1302851690
##########
src/DotPulsar/Internal/Connection.cs:
##########
@@ -336,6 +338,14 @@ public async ValueTask DisposeAsync()
await _stream.DisposeAsync().ConfigureAwait(false);
}
+ public async void MarkInactive()
Review Comment:
I'm not sure if I get your point correctly. I moved the connection disposing
to the lifecycle loop in the ConnectionPool.
But this way, it's hard to add a test for the ConnnectionPool. I have tested
it manually and it seems work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
