shibd commented on code in PR #21060:
URL: https://github.com/apache/pulsar/pull/21060#discussion_r1303954841
##########
pulsar-functions/utils/src/main/java/org/apache/pulsar/functions/utils/SinkConfigUtils.java:
##########
@@ -210,6 +210,13 @@ public static FunctionDetails convert(SinkConfig
sinkConfig, ExtractedSinkDetail
functionDetailsBuilder.setSource(sourceSpecBuilder);
+ if (sinkConfig.getRetainKeyOrdering() != null) {
Review Comment:
Can you add a unit test to cover this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
