liangyepianzhou commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1305001187
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java:
##########
@@ -1449,6 +1449,15 @@ private ByteBuf processMessageChunk(ByteBuf
compressedPayload, MessageMetadata m
// discard message if chunk is out-of-order
if (chunkedMsgCtx == null || chunkedMsgCtx.chunkedMsgBuffer == null
Review Comment:
>Consumer has received chunk-0, then it received chunk-0 again. In this
case, chunkedMsgCtx is not null and msgMetadata.getChunkId() <=
chunkedMsgCtx.lastChunkedMessageId.
>The 2nd case might be expected (I'm not sure) so that consumer should
filter duplicated messages.
This PR does not deduplicate the chunks in a single chunk message on the
broker side.
So, the 2nd case is expected. The [proposal
295](https://github.com/apache/pulsar/pull/21027) is add a patch to do
deduplication of chunks on the broker side. After that the 2nd case should be
an unexpected case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
