BewareMyPower commented on PR #308: URL: https://github.com/apache/pulsar-client-cpp/pull/308#issuecomment-1695377918
Before this patch, `~OpSendMsg` could be called in various places (Search `.*~OpSendMsg.*` in the FlameGraph): - Directly in `ProducerImpl::ackReceived` (4.69%) - `pendingMessagesQueue_.pop_front()` in `ProducerImpl::ackReceived` (0.47%) - Destructor of an Asio callback (`std::tuple<std::shared_ptr<pulsar::ClientConnection>, pulsar::OpSendMsg>`) (1.56%) - `BatchMessageContainerBase::processAndClear` (0.78%) - Directly in `ackReceived` (another call in event loop) (0.16%)  After this patch, `~OpSendMsg` could only be called in `pendingMessagesQueue_.pop_front()` (3.65%)  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
