heesung-sn commented on PR #21065: URL: https://github.com/apache/pulsar/pull/21065#issuecomment-1695927610
> @heesung-sn Should we limit the `batchingMaxMessages` to `200`(default is `1000`), so the `ServiceUnitStateChannelImpl` will not hit this issue? Since the `StrategicTwoPhaseCompactor` uses `1000` as the max num messages in batch. > > https://github.com/apache/pulsar/blob/master/pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/extensions/channel/ServiceUnitStateChannelImpl.java#L301-L307 ``` public class StrategicTwoPhaseCompactor extends TwoPhaseCompactor { private static final Logger log = LoggerFactory.getLogger(StrategicTwoPhaseCompactor.class); private static final int MAX_OUTSTANDING = 500; private static final int MAX_NUM_MESSAGES_IN_BATCH = 1000; private static final int MAX_BYTES_IN_BATCH = 128 * 1024; ``` Yes, if the big batching matters, then we could limit the batching in both the producer and the compactor side in BSC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
