thetumbled commented on code in PR #21078:
URL: https://github.com/apache/pulsar/pull/21078#discussion_r1308356451
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/NamespaceResources.java:
##########
@@ -49,16 +49,18 @@ public class NamespaceResources extends
BaseResources<Policies> {
private final IsolationPolicyResources isolationPolicies;
private final PartitionedTopicResources partitionedTopicResources;
private final MetadataStore configurationStore;
+ private final MetadataStore localStore;
public static final String POLICIES_READONLY_FLAG_PATH =
"/admin/flags/policies-readonly";
private static final String NAMESPACE_BASE_PATH = "/namespace";
private static final String BUNDLE_DATA_BASE_PATH =
"/loadbalance/bundle-data";
- public NamespaceResources(MetadataStore configurationStore, int
operationTimeoutSec) {
+ public NamespaceResources(MetadataStore localStore, MetadataStore
configurationStore, int operationTimeoutSec) {
Review Comment:
1. It seems that we can't allow the `configurationMetadataStore` to be null,
or there will be serious issues.
https://github.com/apache/pulsar/blob/d099ac4fa2f217b9c5f0a5e660c83048e829c5d7/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L752-L762
2. Currently, bundle-data are created/updated by `LoadManager`, and deleted
by `LoadManager` and `NamespaceResources`. It is beneficial to introduce a
`BundleResources` to unify the opeartions to bundle-data. But i think that it
should be introduced as a code optimization instead of bug fix, which need to
be discussed fully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
