heesung-sn commented on code in PR #20948:
URL: https://github.com/apache/pulsar/pull/20948#discussion_r1310500509
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -367,6 +386,11 @@ public MessageDupStatus isDuplicate(PublishContext
publishContext, ByteBuf heade
}
highestSequencedPushed.put(producerName, highestSequenceId);
}
+ // Only put sequence ID into highestSequencedPushed and
+ // highestSequencedPersisted until receive and persistent the last
chunk.
Review Comment:
Shouldn't we check this last chunk in line 387?
`highestSequencedPushed.put(producerName, highestSequenceId);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
