thetumbled commented on code in PR #21078:
URL: https://github.com/apache/pulsar/pull/21078#discussion_r1311023028


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/resources/NamespaceResources.java:
##########
@@ -381,13 +383,13 @@ public CompletableFuture<Void> 
runWithMarkDeleteAsync(TopicName topic,
     // clear resource of `/loadbalance/bundle-data/{tenant}/{namespace}/` in 
metadata-store
     public CompletableFuture<Void> deleteBundleDataAsync(NamespaceName ns) {
         final String namespaceBundlePath = joinPath(BUNDLE_DATA_BASE_PATH, 
ns.toString());
-        return getStore().deleteRecursive(namespaceBundlePath);

Review Comment:
   Not wrong path, but wrong places. There are two metadata store: local store 
and global zk. 
   When deleting a namespace, we will delete znode under the path 
`/loadbalance/bundle-data` in `local` metadata store instead of `global` 
metadata store.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to