coderzc commented on code in PR #21099:
URL: https://github.com/apache/pulsar/pull/21099#discussion_r1311205911
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java:
##########
@@ -1170,15 +1170,14 @@ public void deleteLedgerFailed(ManagedLedgerException
exception, Object ctx) {
private void asyncDeleteCursorWithClearDelayedMessage(String
subscriptionName,
CompletableFuture<Void> unsubscribeFuture) {
- if (!isDelayedDeliveryEnabled()
- || !(brokerService.getDelayedDeliveryTrackerFactory()
instanceof BucketDelayedDeliveryTrackerFactory)) {
- asyncDeleteCursor(subscriptionName, unsubscribeFuture);
- return;
- }
-
PersistentSubscription persistentSubscription =
subscriptions.get(subscriptionName);
if (persistentSubscription == null) {
Review Comment:
This seems to have a data race with
`org.apache.pulsar.broker.service.persistent.PersistentTopic#removeSubscription`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
