gunli opened a new issue, #1088:
URL: https://github.com/apache/pulsar-client-go/issues/1088

   #### Expected behavior
   
   1. Rename the config option 'DisableBlockIfQueueFull' to 'BlockIfQueueFull', 
same as it is in JAVA client; 
   2. After renaming, set the default value to `false`, same as it is in JAVA 
client; 
   
   #### Actual behavior
   1. There is a config option to controls whether Send and SendAsync block if 
producer's message queue is full; 
   2. In JAVA client, this config option is called 'blockIfQueueFull', and the 
default value is `false`, meaning no block if queue is full. 
https://github.com/apache/pulsar/blob/master/pulsar-client/src/main/java/org/apache/pulsar/client/impl/conf/ProducerConfigurationData.java#L85
   3. In Go client, this config option is called `DisableBlockIfQueueFull`, and 
the default value is `false`, meaing block if queue is full. 
https://github.com/apache/pulsar-client-go/blob/master/pulsar/producer.go#L102
   4. The name `DisableBlockIfQueueFull` and the default value `false` is 
"double negative", is difficult to understand.
   
   #### Steps to reproduce
   
   How can we reproduce the issue
   
   #### System configuration
   **Pulsar version**: x.y
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to