TakaHiR07 commented on code in PR #21087:
URL: https://github.com/apache/pulsar/pull/21087#discussion_r1314547217
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java:
##########
@@ -279,12 +279,6 @@ private void
internalRetryableDeleteNamespaceAsync0(boolean force, int retryTime
return old;
});
}
- allUserCreatedTopics.removeIf(t ->
-
allPartitionedTopics.contains(TopicName.get(t).getPartitionedTopicName()));
- allSystemTopics.removeIf(t ->
-
allPartitionedTopics.contains(TopicName.get(t).getPartitionedTopicName()));
- topicPolicy.removeIf(t ->
-
allPartitionedTopics.contains(TopicName.get(t).getPartitionedTopicName()));
Review Comment:
The retry logic in
https://github.com/apache/pulsar/blob/e59c850753f2a1d08e4df63bf8862c7cb5db4e71/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L328-L342
make it hard to add test. Because this wrong behaviour also throw
KeeperException.NotEmptyException, which would be caught and retry
internalRetryableDeleteNamespaceAsync0(). Actually it should succeed without
retry
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
