horizonzy commented on PR #21096: URL: https://github.com/apache/pulsar/pull/21096#issuecomment-1704984751
> > > > > > It makes sense, we should print a debug log when the allGroupsBookieMapping is null. > > > > > > > > > > > > > > > Yes, sure. > > > > > > > > > > > > There is a case that needs discussed, we only update the rack config when the `opt.isPresent`. If the user deletes the zk nodes of path `/bookies`, the `opt.isPresent` will be false. Shall we delete the cached rack config or still use it? > > > > > > > > > @horizonzy We need to delete the cached rack configuration. > > > > > > What do you think of it? > > @horizonzy Do checking the exception type work? If the exception is a NoNode exception, update the cached rack configuration to `null`. It doesn't work. The zk metadata store handles it separately, not throw exceptions. https://github.com/apache/pulsar/blob/b26ee8a194ebebff05fca12d49d4f5e4b798be48/pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/ZKMetadataStore.java#L267-L269 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
