BewareMyPower commented on code in PR #21116:
URL: https://github.com/apache/pulsar/pull/21116#discussion_r1314760609
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PersistentAcknowledgmentsGroupingTracker.java:
##########
@@ -124,7 +124,19 @@ public boolean isDuplicate(MessageId messageId) {
// Already included in a cumulative ack
return true;
} else {
- return
pendingIndividualAcks.contains(MessageIdAdvUtils.discardBatch(messageIdAdv));
+ // If "batchIndexAckEnabled" is false, the batched messages
acknowledgment will be traced by
+ // pendingIndividualAcks. So no matter what type the message ID
is, check with "pendingIndividualAcks"
+ // first.
+ if
(pendingIndividualAcks.contains(MessageIdAdvUtils.discardBatch(messageIdAdv))) {
Review Comment:
`MessageIdAdvUtils` was first introduced since 3.0.0, so if you're going to
cherry-pick it to 2.11 or earlier, you need to adjust the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
