ethqunzhong opened a new pull request, #21125:
URL: https://github.com/apache/pulsar/pull/21125

   ### Motivation
   Lack of a metric to characterize the latency of offload: 
   the time interval between when a ledger starts offloading and its creation 
time. 
   Ideally, in an online production environment, this delay should be slightly 
greater than managedLedgerMinLedgerRolloverTimeMinutes(default 10min)
   
![image](https://github.com/apache/pulsar/assets/16517186/3701164b-50ac-4018-8cd8-004362516c85)
   
   This metric can help us track the timeliness of topic offloading. 
   
   
   ### Modifications
   update `LedgerOffloaderStats` with `recordOffloadDataLatency` to record 
offloadDataLatency metrics.(The time interval between ledger creation and the 
start of offloading, means the delay of offloading)
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change is already covered by existing tests.
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If the box was checked, please highlight the changes*
   
   - [ ] Dependencies (add or upgrade a dependency)
   - [ ] The public API
   - [ ] The schema
   - [ ] The default values of configurations
   - [ ] The threading model
   - [ ] The binary protocol
   - [ ] The REST endpoints
   - [ ] The admin CLI options
   - [x] The metrics
   - [ ] Anything that affects deployment
   
   ### Documentation
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   
   ### Matching PR in forked repository
   
   PR in forked repository:  https://github.com/ethqunzhong/pulsar/pull/9
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to