Technoboy- commented on code in PR #21117:
URL: https://github.com/apache/pulsar/pull/21117#discussion_r1315473681
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/policies/TableViewTopicPolicyService.java:
##########
@@ -0,0 +1,361 @@
+package org.apache.pulsar.broker.policies;
+
+import static java.util.Objects.requireNonNull;
+import static java.util.concurrent.CompletableFuture.completedFuture;
+import static java.util.concurrent.CompletableFuture.failedFuture;
+import static java.util.concurrent.CompletableFuture.supplyAsync;
+import com.google.common.collect.Sets;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.pulsar.broker.PulsarService;
+import org.apache.pulsar.broker.namespace.NamespaceBundleOwnershipListener;
+import org.apache.pulsar.broker.namespace.NamespaceService;
+import org.apache.pulsar.broker.service.BrokerServiceException;
+import org.apache.pulsar.broker.service.TopicPoliciesService;
+import org.apache.pulsar.broker.service.TopicPolicyListener;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.Schema;
+import org.apache.pulsar.client.api.TableView;
+import org.apache.pulsar.common.events.ActionType;
+import org.apache.pulsar.common.events.EventType;
+import org.apache.pulsar.common.events.PulsarEvent;
+import org.apache.pulsar.common.events.TopicPoliciesEvent;
+import org.apache.pulsar.common.naming.NamespaceBundle;
+import org.apache.pulsar.common.naming.NamespaceName;
+import org.apache.pulsar.common.naming.SystemTopicNames;
+import org.apache.pulsar.common.naming.TopicName;
+import org.apache.pulsar.common.policies.data.TopicPolicies;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.function.Supplier;
+
+@Slf4j
+public class TableViewTopicPolicyService implements TopicPoliciesService {
+ private final String clusterName;
+ private final NamespaceService namespaceService;
+ private final Map<NamespaceName,
CompletableFuture<TableView<PulsarEvent>>> views;
+ private final Map<NamespaceName, CompletableFuture<Producer<PulsarEvent>>>
writers;
+ private final Map<TopicName, List<TopicPolicyListener<TopicPolicies>>>
listeners;
+ private final Supplier<PulsarClient> clientSupplier;
+
+ public TableViewTopicPolicyService(@Nonnull PulsarService pulsarService) {
+ requireNonNull(pulsarService);
+ this.clientSupplier = () -> {
+ try {
+ return pulsarService.getClient();
+ } catch (Throwable ex) {
+ throw new RuntimeException(ex);
+ }
+ };
+ this.namespaceService = pulsarService.getNamespaceService();
+ this.views = new ConcurrentHashMap<>();
+ this.writers = new ConcurrentHashMap<>();
+ this.listeners = new ConcurrentHashMap<>();
+ this.clusterName = pulsarService.getConfiguration().getClusterName();
+ }
+
+ @Override
+ public @Nonnull CompletableFuture<Void> deleteTopicPoliciesAsync(@Nonnull
TopicName topicName) {
+ return updateTopicPoliciesAsync(topicName, null);
+ }
+
+ @Override
+ public @Nonnull CompletableFuture<Void> updateTopicPoliciesAsync(@Nonnull
TopicName topicName,
+ @Nullable
TopicPolicies policies) {
+ if (topicName == null) {
+ return failedFuture(new NullPointerException());
Review Comment:
”new NullPointerException(”topicName is null“)“
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/policies/TableViewTopicPolicyService.java:
##########
@@ -0,0 +1,361 @@
+package org.apache.pulsar.broker.policies;
+
+import static java.util.Objects.requireNonNull;
+import static java.util.concurrent.CompletableFuture.completedFuture;
+import static java.util.concurrent.CompletableFuture.failedFuture;
+import static java.util.concurrent.CompletableFuture.supplyAsync;
+import com.google.common.collect.Sets;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.pulsar.broker.PulsarService;
+import org.apache.pulsar.broker.namespace.NamespaceBundleOwnershipListener;
+import org.apache.pulsar.broker.namespace.NamespaceService;
+import org.apache.pulsar.broker.service.BrokerServiceException;
+import org.apache.pulsar.broker.service.TopicPoliciesService;
+import org.apache.pulsar.broker.service.TopicPolicyListener;
+import org.apache.pulsar.client.api.Producer;
+import org.apache.pulsar.client.api.PulsarClient;
+import org.apache.pulsar.client.api.Schema;
+import org.apache.pulsar.client.api.TableView;
+import org.apache.pulsar.common.events.ActionType;
+import org.apache.pulsar.common.events.EventType;
+import org.apache.pulsar.common.events.PulsarEvent;
+import org.apache.pulsar.common.events.TopicPoliciesEvent;
+import org.apache.pulsar.common.naming.NamespaceBundle;
+import org.apache.pulsar.common.naming.NamespaceName;
+import org.apache.pulsar.common.naming.SystemTopicNames;
+import org.apache.pulsar.common.naming.TopicName;
+import org.apache.pulsar.common.policies.data.TopicPolicies;
+import javax.annotation.Nonnull;
+import javax.annotation.Nullable;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.concurrent.CompletableFuture;
+import java.util.concurrent.ConcurrentHashMap;
+import java.util.concurrent.CopyOnWriteArrayList;
+import java.util.function.Supplier;
+
+@Slf4j
+public class TableViewTopicPolicyService implements TopicPoliciesService {
+ private final String clusterName;
+ private final NamespaceService namespaceService;
+ private final Map<NamespaceName,
CompletableFuture<TableView<PulsarEvent>>> views;
+ private final Map<NamespaceName, CompletableFuture<Producer<PulsarEvent>>>
writers;
+ private final Map<TopicName, List<TopicPolicyListener<TopicPolicies>>>
listeners;
+ private final Supplier<PulsarClient> clientSupplier;
+
+ public TableViewTopicPolicyService(@Nonnull PulsarService pulsarService) {
+ requireNonNull(pulsarService);
+ this.clientSupplier = () -> {
+ try {
+ return pulsarService.getClient();
+ } catch (Throwable ex) {
+ throw new RuntimeException(ex);
+ }
+ };
+ this.namespaceService = pulsarService.getNamespaceService();
+ this.views = new ConcurrentHashMap<>();
+ this.writers = new ConcurrentHashMap<>();
+ this.listeners = new ConcurrentHashMap<>();
+ this.clusterName = pulsarService.getConfiguration().getClusterName();
+ }
+
+ @Override
+ public @Nonnull CompletableFuture<Void> deleteTopicPoliciesAsync(@Nonnull
TopicName topicName) {
+ return updateTopicPoliciesAsync(topicName, null);
+ }
+
+ @Override
+ public @Nonnull CompletableFuture<Void> updateTopicPoliciesAsync(@Nonnull
TopicName topicName,
+ @Nullable
TopicPolicies policies) {
+ if (topicName == null) {
+ return failedFuture(new NullPointerException());
Review Comment:
”new NullPointerException(”topicName is null“)“
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
