codelipenghui commented on code in PR #21107:
URL: https://github.com/apache/pulsar/pull/21107#discussion_r1315899927
##########
pulsar-common/src/main/java/org/apache/pulsar/common/util/collections/ConcurrentLongLongPairHashMap.java:
##########
@@ -322,15 +324,15 @@ private static final class Section extends StampedLock {
LongPair get(long key1, long key2, int keyHash) {
long stamp = tryOptimisticRead();
boolean acquiredLock = false;
- int bucket = signSafeMod(keyHash, capacity);
+ int bucketIndex = signSafeMod(keyHash, capacity) * ITEM_SIZE;
Review Comment:
The modern Java compilers are smart enough to recognize when multiplication
is equivalent to a bit shift and can optimize the multiplication operation to
use a bit shift instead. It's better to focus on writing clear, readable code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
