liangyepianzhou commented on code in PR #20559:
URL: https://github.com/apache/pulsar/pull/20559#discussion_r1317029743
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBufferProvider.java:
##########
@@ -51,5 +52,5 @@ static TransactionBufferProvider newProvider(String
providerClassName) throws IO
* @param originTopic
* @return
*/
- TransactionBuffer newTransactionBuffer(Topic originTopic);
+ TransactionBuffer newTransactionBuffer(Topic originTopic, PositionImpl
startUsedPosition);
Review Comment:
Maybe we do not need to add the new API. We can require the
startUsedPosition in the Transaction Buffer again.
It is still a break-changing even though we added a new default method
because we changed the logic in the PersistentTopic that called this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
