RobertIndie commented on code in PR #21103:
URL: https://github.com/apache/pulsar/pull/21103#discussion_r1317982697
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -348,6 +363,10 @@ public void testMaxPendingChunkMessages() throws Exception
{
assertEquals(receivedMsg.getValue(), "chunk-1-0|chunk-1-1|");
consumer.acknowledge(receivedMsg);
+
assertEquals(admin.topics().getStats(topicName).getSubscriptions().get(subName)
+ .getNonContiguousDeletedMessagesRanges(), 0);
Review Comment:
Need to remove this line?
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MessageChunkingTest.java:
##########
@@ -319,15 +320,29 @@ private void sendSingleChunk(Producer<String> producer,
String uuid, int chunkId
msg.send();
}
+ /**
+ * This test used to test the consumer configuration of
maxPendingChunkedMessage.
+ * If we set maxPendingChunkedMessage is 1 that means only one incomplete
chunk message can be store in this
+ * consumer.
+ * For example:
+ * ChunkMessage1 chunk-1: uuid = 0, chunkId = 0, totalChunk = 2;
+ * ChunkMessage2 chunk-1: uuid = 1, chunkId = 0, totalChunk = 2;
+ * ChunkMessage2 chunk-2: uuid = 1, chunkId = 1, totalChunk = 2;
+ * ChunkMessage1 chunk-2: uuid = 0, chunkId = 1, totalChunk = 2;
+ * The chunk-1 in the ChunkMessage1 and ChunkMessage all is incomplete.
Review Comment:
```suggestion
* The chunk-1 in the ChunkMessage1 and ChunkMessage2 all is incomplete.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
