Denovo1998 commented on code in PR #19086:
URL: https://github.com/apache/pulsar/pull/19086#discussion_r1318737298
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1017,11 +1017,22 @@ public CompletableFuture<Optional<Topic>>
getTopic(final TopicName topicName, bo
}
final boolean isPersistentTopic =
topicName.getDomain().equals(TopicDomain.persistent);
if (isPersistentTopic) {
- return topics.computeIfAbsent(topicName.toString(), (k) -> {
- return this.loadOrCreatePersistentTopic(k,
createIfMissing, properties);
+ return topics.computeIfAbsent(topicName.toString(), (tpName)
-> {
+ if (topicName.isPartitioned()) {
+ return
fetchPartitionedTopicMetadataAsync(TopicName.get(topicName.getPartitionedTopicName()))
+ .thenCompose((metadata) -> {
+ // Allow crate non-partitioned persistent
topic that name includes `partition`
Review Comment:
@mattisonchao There's a spelling problem here. **crate -> create**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
