horizonzy commented on code in PR #21188:
URL: https://github.com/apache/pulsar/pull/21188#discussion_r1327055923
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/bookkeeper/PulsarLedgerUnderreplicationManager.java:
##########
@@ -105,14 +105,17 @@ long getLedgerNodeVersion() {
private final String urLockPath;
private final String layoutPath;
private final String lostBookieRecoveryDelayPath;
+ private final String replicationDisablePath;
private final String checkAllLedgersCtimePath;
private final String placementPolicyCheckCtimePath;
private final String replicasCheckCtimePath;
private final MetadataStoreExtended store;
- private BookkeeperInternalCallbacks.GenericCallback<Void>
replicationEnabledListener;
- private BookkeeperInternalCallbacks.GenericCallback<Void>
lostBookieRecoveryDelayListener;
Review Comment:
> Why change the type to a collection? Only the latest event needs to be
notified, right?
Not, if the user registers two callbacks, the previous callback shouldn't be
overridden. It also need trigger callback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
