merlimat commented on issue #4623: Fixed the default port for https and http in 
admin client
URL: https://github.com/apache/pulsar/pull/4623#issuecomment-507435739
 
 
   > @merlimat Is this a breaking change? For example, if a user has set up a 
pulsar cluster and use https://example.pulsar.com. Right now it will be 
connecting to port 8443, because the default http and https ports for Pulsar 
are 8080 and 8443. With your change, the client will be connect to 80 and 443, 
but fail.
   
   I think the breaking change was in  #3249. Before that, `https` was 
correctly resolving to 443 and `http` to 80.
   
   > If Pulsar's default http and https ports are 8080 and 8443, we should try 
to stick to Pulsar's default value, not the general http and https default 
values. Otherwise it might be break Pulsar 2.3.x clients, right?
   
   The fact that on server side we use 8080 and 8443 by default, shouldn't mean 
that a client should hide the port for that. 
   
   This is seriously confusing. `https://my-broker.com` must mean port 443. If 
you use a different client, other than pulsar admin, you would have to specify 
`:443`. 
   
   Now, imagine debugging why the same url works in pulsar-admin but it doesn't 
if you try with http directly.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to