JooHyukKim commented on code in PR #20764:
URL: https://github.com/apache/pulsar/pull/20764#discussion_r1328742413
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java:
##########
@@ -1311,23 +1297,16 @@ void run() throws PulsarAdminException {
BacklogQuota.Builder builder =
BacklogQuota.builder().retentionPolicy(policy);
if (backlogQuotaType ==
BacklogQuota.BacklogQuotaType.destination_storage) {
// set quota by storage size
- if (limitStr == null) {
+ if (limit == null) {
Review Comment:
Hmmm, I did not touch `limit` and `limitTimeInSec` because they both have
meaningful exception message such as...
```java
throw new ParameterException("Quota type of 'destination_storage' needs
a size limit");
```
... this, so may not fit, and plus `Validator`s and `Converter`s are both
passed static via annotation, so... kinda tricky.
##########
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java:
##########
@@ -2225,62 +2178,7 @@ void run() throws PulsarAdminException {
+ " if s3 offload enabled");
}
- int maxBlockSizeInBytes =
OffloadPoliciesImpl.DEFAULT_MAX_BLOCK_SIZE_IN_BYTES;
- if (StringUtils.isNotEmpty(maxBlockSizeStr)) {
- long maxBlockSize = validateSizeString(maxBlockSizeStr);
- if (positiveCheck("MaxBlockSize", maxBlockSize)
Review Comment:
Right, they both are unused methods now. Done, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
