michaeljmarshall commented on code in PR #20084:
URL: https://github.com/apache/pulsar/pull/20084#discussion_r1330650097
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -850,6 +850,17 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
doc = "Enable check for minimum allowed client library version"
)
private boolean clientLibraryVersionCheckEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Minimum client version allowed by broker else broker will
reject connection."
+ + "(It's useful when client lib doesn't support specific feature
and feature "
+ + "might be required by broker to apply globally on all topics."
+ + "(eg: all clients must be on V20 to perform cloud migration)"
Review Comment:
Since it's an int, should we just say 20, not V20?
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -850,6 +850,17 @@ The delayed message index time step(in seconds) in per
bucket snapshot segment,
doc = "Enable check for minimum allowed client library version"
)
private boolean clientLibraryVersionCheckEnabled = false;
+
+ @FieldContext(
+ category = CATEGORY_SERVER,
+ dynamic = true,
+ doc = "Minimum client version allowed by broker else broker will
reject connection."
+ + "(It's useful when client lib doesn't support specific feature
and feature "
+ + "might be required by broker to apply globally on all topics."
+ + "(eg: all clients must be on V20 to perform cloud migration)"
+ )
+ private int clientMinVersionAllowed = -1;
Review Comment:
Would it make sense to add proto or protocol to the name to disambiguate it
from the library version?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
