eolivelli commented on code in PR #20084:
URL: https://github.com/apache/pulsar/pull/20084#discussion_r1330704225
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -684,6 +686,14 @@ ByteBuf createConsumerStatsResponse(Consumer consumer,
long requestId) {
// complete the connect and sent newConnected command
private void completeConnect(int clientProtoVersion, String clientVersion)
{
+ if (clientMinVersionAllowed >= 0 && clientMinVersionAllowed >
clientProtoVersion) {
+ log.info("[{}] client with version {} must be upgraded to {}",
remoteAddress, clientProtoVersion,
+ clientMinVersionAllowed);
+ final ByteBuf msg = Commands.newError(-1,
ServerError.UnsupportedVersionError,
+ "Upgrade version to " + clientMinVersionAllowed + " or
higher");
Review Comment:
What about 'upgrade your client to a version that supports protocol version
...'
Otherwise it seems that you have to upgrade to Pulsar 20
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
