hanmz commented on code in PR #21203:
URL: https://github.com/apache/pulsar/pull/21203#discussion_r1331003475


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java:
##########
@@ -116,6 +118,11 @@ public String getRemoteCluster() {
     // This method needs to be synchronized with disconnects else if there is 
a disconnect followed by startProducer
     // the end result can be disconnect.
     public synchronized void startProducer() {
+        if (isClosed) {

Review Comment:
   Here is another way to modify it, check replicator exist in method 
checkTopicActiveAndRetryStartProducer.
   Do you think this way is more reasonable?
   
   <img width="1116" alt="image" 
src="https://github.com/apache/pulsar/assets/16524922/8d21633d-9d02-4698-8953-ed8a4c47c6f8";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to