shibd commented on code in PR #21244:
URL: https://github.com/apache/pulsar/pull/21244#discussion_r1336566316


##########
pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/decoder/avro/PulsarAvroRowDecoderFactory.java:
##########
@@ -122,6 +123,9 @@ private Type parseAvroPrestoType(String fieldName, Schema 
schema) {
         switch (type) {
             case STRING:
             case ENUM:
+                if (logicalType != null && 
logicalType.equals(LogicalTypes.uuid())) {

Review Comment:
   Yes, but the logical type of UUID belongs to `STRING` and not `ENUM`. 
   
   Putting it in STRING alone makes it more readable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to