Jason918 commented on code in PR #21210:
URL: https://github.com/apache/pulsar/pull/21210#discussion_r1336588533
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -2791,6 +2791,54 @@ public void deleteFailed(ManagedLedgerException ex,
Object ctx) {
}
}
+ /**
+ * Manually acknowledge all entries from startPosition to endPosition.
+ * - Since this is an uncommon event, we focus on maintainability. So we
do not modify
+ * {@link #individualDeletedMessages} and {@link #batchDeletedIndexes},
but call
+ * {@link #asyncDelete(Position, AsyncCallbacks.DeleteCallback, Object)}.
+ * - This method is valid regardless of the consumer ACK type.
+ * - If there is a consumer ack request after this event, it will also
work.
+ */
+ public void skipNonRecoverableEntries(Position startPosition, Position
endPosition){
Review Comment:
It's better to add a unit test for this method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
