hanmz commented on code in PR #21203:
URL: https://github.com/apache/pulsar/pull/21203#discussion_r1336633095
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractReplicator.java:
##########
@@ -116,6 +118,13 @@ public String getRemoteCluster() {
// This method needs to be synchronized with disconnects else if there is
a disconnect followed by startProducer
// the end result can be disconnect.
public synchronized void startProducer() {
+ // This method comes from some actives call and may be call again
after disconnect
+ // so here we will first mark isClosed is false
+ isClosed = false;
Review Comment:
There is currently no clear indication that this replicator will not be used
again after it is `disconnect`.
Mabey it is not very reasonable to use the `close` status identifier here,
but it can work normally.
I think it is also reasonable to use some other markers as judgment
conditions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
