BewareMyPower commented on code in PR #21245:
URL: https://github.com/apache/pulsar/pull/21245#discussion_r1337141115
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Topic.java:
##########
@@ -127,6 +128,14 @@ default long getEntryTimestamp() {
default void setEntryTimestamp(long entryTimestamp) {
}
+
+ default MessageIdData getMessageIdData() {
+ return null;
+ }
+
+ default ByteBuf getHeaderAndPayload() {
+ return null;
+ }
Review Comment:
It increases two methods to the public interface (`BrokerInterceptor`, which
uses `Topic.TopicPublishContext`). We need a PIP for such changes.
For example, [https://github.com/apache/pulsar/pull/17269](PIP-204:
Extensions for broker interceptor) adds the `getMsgSize`,
`getEntryTimestamp`/`setEntryTimestamp` methods to this interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
