nodece commented on code in PR #21251:
URL: https://github.com/apache/pulsar/pull/21251#discussion_r1338249400
##########
pulsar-metadata/src/test/java/org/apache/pulsar/metadata/impl/EtcdMetadataStoreTest.java:
##########
@@ -128,4 +117,19 @@ public void testTlsInstance() throws Exception {
assertTrue(store.exists("/test").join());
}
+
+
+ private synchronized String
getEtcdClusterConnectString(EtcdClusterExtension.Builder builder) {
+ String etcdUrl = System.getProperty("pulsar.metadatastore.etcd.url");
+ if(!StringUtils.isBlank(etcdUrl)){
+ return "etcd:"+etcdUrl;
+ }
+ @Cleanup
Review Comment:
The `@Cleanup` should call the `close()`, which seems to cause the etcd
cluster to shutdown after calling the `getEtcdClusterConnectString()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
