BewareMyPower commented on code in PR #321:
URL: https://github.com/apache/pulsar-client-cpp/pull/321#discussion_r1338358971
##########
lib/AckGroupingTracker.cc:
##########
@@ -42,6 +44,14 @@ void AckGroupingTracker::doImmediateAck(const MessageId&
msgId, ResultCallback c
}
return;
}
+ if (auto chunkMessageId =
+
std::dynamic_pointer_cast<ChunkMessageIdImpl>(Commands::getMessageIdImpl(msgId)))
{
+ auto msgIdList = chunkMessageId->moveChunkedMessageIds();
+
doImmediateAck(std::set<MessageId>(std::make_move_iterator(msgIdList.begin()),
+
std::make_move_iterator(msgIdList.end())),
Review Comment:
If the `ackType` is cumulative, we should acknowledge the last message id
cumulatively instead of acknowledging all message ids individually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
