liangyepianzhou opened a new pull request, #21272: URL: https://github.com/apache/pulsar/pull/21272
Reopen https://github.com/apache/pulsar/pull/21162 ## Motivation Every topic within a namespace has a common system topic that stores the transaction buffer snapshot. Whenever a topic is loaded and transactions are enabled, it reads the snapshot system topic from the earliest position once. In scenarios where there are numerous topics within a namespace, repeated reads on the system topic occur frequently. This results in a large number of connections to bookies. ## Modifications To address this issue, we propose optimizing the TableView API and implementing it within the SnapshotService. This optimization would ensure that the snapshot system topic is read only once, from the beginning to the end, eliminating any unnecessary repeated reads. The process of accessing the system topic in the new approach can be illustrated by referring to the following diagram: <img width="891" alt="image" src="https://github.com/apache/pulsar/assets/55571188/abec59aa-87c6-42e7-8e33-4dc6b1e5d558";> ### Verifying this change - [ ] Make sure that the change passes the CI checks. *(Please pick either of the following options)* This change is a trivial rework / code cleanup without any test coverage. *(or)* This change is already covered by existing tests, such as *(please describe tests)*. *(or)* This change added tests and can be verified as follows: *(example:)* - *Added integration tests for end-to-end deployment with large payloads (10MB)* - *Extended integration test for recovery after broker failure* ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [ ] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
