ivankelly opened a new pull request #4669: Don't consider deleted schema when 
checking compatibility
URL: https://github.com/apache/pulsar/pull/4669
 
 
   feca5bbb changed topic delete logic to delete the schema when the
   topic is deleted (though this only seems to be enabled for idle topic
   GC). This exposed a bug in compatibility checking whereby if the a
   subscription tries to attach to the topic, even if using the same
   schema as had been used previously, a compatibility exception will be
   thrown.
   
   The root cause was a logic bomb in the compatibility check.
   !(A || B) && C where it should have been !(A || B) || C.
   
   The issue doesn't affect producers because the check was already
   correct there.
   
   I've also updated the check for transitive compatibility to remove the
   prefix of schemas before the deleted schema. Previously this was
   throwing an NPE on the broker as it couldn't decode the deleted
   schema.
   
   This issue was discovered by failures in the healthcheck. The check
   period (5 minutes) was longer than the GC period (60 seconds). I would
   expect it to hit quite often in other scenarios also.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to