liangyuanpeng commented on code in PR #21253:
URL: https://github.com/apache/pulsar/pull/21253#discussion_r1353850095
##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/impl/EtcdMetadataStore.java:
##########
@@ -109,9 +109,9 @@ public EtcdMetadataStore(String metadataURL,
MetadataStoreConfig conf, boolean e
try {
this.client = newEtcdClient(metadataURL, conf);
this.kv = client.getKVClient();
- this.client.getWatchClient().watch(ByteSequence.from("\0",
StandardCharsets.UTF_8),
+ this.client.getWatchClient().watch(ByteSequence.from("/",
StandardCharsets.UTF_8),
Review Comment:
> This modification is beyond the scope of the PR description.
This is not true, The value here is meaningless to the old method, but the
new method needs to fill in the key as prefix. Not change it and you will get
the red CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
