mattisonchao commented on code in PR #21379:
URL: https://github.com/apache/pulsar/pull/21379#discussion_r1361910279
##########
pulsar-websocket/src/main/java/org/apache/pulsar/websocket/AbstractWebSocketHandler.java:
##########
@@ -67,25 +67,29 @@ public abstract class AbstractWebSocketHandler extends
WebSocketAdapter implemen
protected final WebSocketService service;
protected final HttpServletRequest request;
- protected final TopicName topic;
+ protected TopicName topic;
protected final Map<String, String> queryParams;
private static final String PULSAR_AUTH_METHOD_NAME =
"X-Pulsar-Auth-Method-Name";
protected final ObjectReader consumerCommandReader =
ObjectMapperFactory.getMapper().reader().forType(ConsumerCommand.class);
private ScheduledFuture<?> pingFuture;
+ protected String topicsPattern;
+
+ protected String topics;
Review Comment:
Is it possible to move the `topic` parameter to the `topics` parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
