rdhabalia opened a new pull request, #21409:
URL: https://github.com/apache/pulsar/pull/21409
### Motivation
This PR #14648 is incorrectly introduced, causing broker service
unavailability while upgrading brokers in heterogeneous hardware config
clusters. Sometime broker can’t find nic speed as it’s not defined into
multiple types of VM which is very well know behavior and that’s why broker
handles such usecase while managing load report by avoiding n/w bandwidth
metrics.
This PR #14648 was introduced by completely ignoring heterogeneous hardware
configuration cluster usecase because of that broker upgrade in that cluster
has brought down all those VM brokers and can cause the outage. that PR also
had test cases failing due to the same reason and it was addressed by another
hack by configuring `loadBalancerOverrideBrokerNicSpeedGbps`. again
`loadBalancerOverrideBrokerNicSpeedGbps` doesn’t work in heterogeneous h/w
config cluster as we can not configure every different broker with different
config file.
so, either broker can perform auto-detect nic speed, if not then there has
to be an option to ignore n/w bandwidth calculation which was the existing
behavior by considering different h/w config cluster which was completely
ignored by this PR #14648 and that has to be removed. if anyone wants to add
restriction then we can add a config but I don’t see any value in introducing
another config just to avoid this warning message. so, this PR fixes this
behavior which are causing service outage with this feature upgrade.
### Modifications
Remove incorrect restriction that makes Pulsar unusable for broker service
deployed on heterogeneous hw configuration with VMs.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update
later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions
will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since
the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed
in
a forked repository.
The tests will be run in the forked repository until all PR review comments
have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
