asafm commented on code in PR #399:
URL: https://github.com/apache/pulsar/pull/399#discussion_r1367902327
##########
pulsar-broker/src/main/java/com/yahoo/pulsar/broker/service/Consumer.java:
##########
@@ -546,5 +553,15 @@ public Subscription getSubscription() {
return subscription;
}
+ private int addAndGetUnAckedMsgs(Consumer consumer, int ackedMessages) {
Review Comment:
@rdhabalia Why did you call this `ackedMessages` while you're adding
(`addUnackedMessages`) - it's very confusing. I had to search through the code
to find you added `-` to it 2 calls up the stack. Very time consuming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
