liangyepianzhou commented on code in PR #21246:
URL: https://github.com/apache/pulsar/pull/21246#discussion_r1369768062
##########
pulsar-common/src/main/proto/PulsarApi.proto:
##########
@@ -399,6 +399,14 @@ message CommandSubscribe {
// The consumer epoch, when exclusive and failover consumer redeliver
unack message will increase the epoch
optional uint64 consumer_epoch = 19;
+
+ enum IsolationLevel {
Review Comment:
@codelipenghui Should we increase `ProtocolVersion`?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherSingleActiveConsumer.java:
##########
@@ -366,6 +367,11 @@ protected void readMoreEntries(Consumer consumer) {
}
}
+ private PositionImpl getMaxReadPosition() {
+ return subscription.getIsolationLevel() ==
IsolationLevel.READ_COMMITTED ?
+ topic.getMaxReadPosition() : PositionImpl.LATEST;
Review Comment:
```suggestion
topic.getMaxReadPosition() :
topic.getManagedLedger().getLastConfirmedEntry()
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -354,6 +356,11 @@ public synchronized void readMoreEntries() {
}
}
+ private PositionImpl getMaxReadPosition() {
+ return subscription.getIsolationLevel() ==
IsolationLevel.READ_COMMITTED ?
+ topic.getMaxReadPosition() : PositionImpl.LATEST;
Review Comment:
```suggestion
topic.getMaxReadPosition() :
topic.getManagedLedger().getLastConfirmedEntry()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
