asafm commented on code in PR #15095:
URL: https://github.com/apache/pulsar/pull/15095#discussion_r1370009523
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/Consumer.java:
##########
@@ -352,9 +352,9 @@ public Future<Void> sendMessages(final List<? extends
Entry> entries, EntryBatch
return writeAndFlushPromise;
}
- private void incrementUnackedMessages(int ackedMessages) {
+ private void incrementUnackedMessages(int unackedMessages) {
Review Comment:
Yeah, but we also call this with ackedMessages as a negative counter. Yep -
very confusing. Very
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
