lhotari opened a new pull request, #21443:
URL: https://github.com/apache/pulsar/pull/21443

   ### Motivation
   
   LoadBalancerTest leaks some threads. 
   
   ### Modifications
   
   - remove the unused thread pool
   - while debugging, it revealed that testLeaderElection method caused some 
thread leaks. 
     - the logic to prevent duplicate calls to `PulsarService.close()` isn't 
needed anymore. 
     - removing this logic fixed the issue although it doesn't seem to be 
obvious from the code since it looks like cleanup was happening properly also 
before making these changes.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update 
later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to