dao-jun commented on code in PR #1108:
URL: https://github.com/apache/pulsar-client-go/pull/1108#discussion_r1372612685
##########
pulsar/schema.go:
##########
@@ -178,7 +180,7 @@ func (js *JSONSchema) Decode(data []byte, v interface{})
error {
}
func (js *JSONSchema) Validate(message []byte) error {
- return js.Decode(message, nil)
+ return nil
Review Comment:
`Schema.Validate` method has never been called elsewhere before, but in
actually, these methods will panic once they are called.
The second param cannot be nil.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
