liangyepianzhou commented on code in PR #21417:
URL: https://github.com/apache/pulsar/pull/21417#discussion_r1372714982
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/TableViewImpl.java:
##########
@@ -230,25 +230,35 @@ private void handleMessage(Message<T> msg) {
}
}
- private CompletableFuture<Reader<T>> readAllExistingMessages(Reader<T>
reader) {
+ @Override
+ public CompletableFuture<Void> refreshAsync() {
+ return reader.thenCompose(reader -> readAllExistingMessages(reader,
false));
+ }
+
+ @Override
+ public void refresh() throws PulsarClientException {
+ refreshAsync().join();
+ }
+
+ private CompletableFuture<Void> readAllExistingMessages(Reader<T> reader,
boolean readTailMessages) {
long startTime = System.nanoTime();
AtomicLong messagesRead = new AtomicLong();
- CompletableFuture<Reader<T>> future = new CompletableFuture<>();
- readAllExistingMessages(reader, future, startTime, messagesRead);
+ CompletableFuture<Void> future = new CompletableFuture<>();
+ readAllExistingMessages(reader, future, startTime, messagesRead,
readTailMessages);
return future;
}
- private void readAllExistingMessages(Reader<T> reader,
CompletableFuture<Reader<T>> future, long startTime,
- AtomicLong messagesRead) {
+ private void readAllExistingMessages(Reader<T> reader,
CompletableFuture<Void> future, long startTime,
+ AtomicLong messagesRead, boolean
readTailMessages) {
reader.hasMessageAvailableAsync()
.thenAccept(hasMessage -> {
if (hasMessage) {
reader.readNextAsync()
.thenAccept(msg -> {
messagesRead.incrementAndGet();
handleMessage(msg);
- readAllExistingMessages(reader, future,
startTime, messagesRead);
+ readAllExistingMessages(reader, future,
startTime, messagesRead, readTailMessages);
Review Comment:
Yes, we can work on https://github.com/apache/pulsar/pull/21270 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
