wojtekkedzior opened a new pull request, #21454: URL: https://github.com/apache/pulsar/pull/21454
<!-- Either this PR fixes an issue, --> Improve the default cluster auto-failvoer probe to allow for custom logic. <!-- If the PR belongs to a PIP, please add the PIP link here --> PIP: n/a ### Motivation The default mechanism used to guage whether a cluster is up or not relies on resolving the DNS of a given cluster. This is the only option for clients which have only one entry point to pulsar, however in my scenario most of my microservices are deployed next to Pulsar and can utilise other ways of checking if the clusters are indeed alive. ### Modifications Kept the existing DNS resolution as the default when the client does not specify its own probe. The default is applied to both the primary and all secondary cluster URLs. Two new methods allow a client to attached their own probes to the URL for their clusters. ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change is already covered by existing tests, such as the AutoClusterFailover which tests whether a fail over will occur based on the results of probes. ### Does this pull request potentially affect one of the following parts: <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> *If the box was checked, please highlight the changes* - [ ] Dependencies (add or upgrade a dependency) - [x] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment * note: This PR adds two new methods to the client API. ### Documentation <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. --> - [ ] `doc` <!-- Your PR contains doc changes. --> - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later --> - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs --> - [x] `doc-complete` <!-- Docs have been already added --> ### Matching PR in forked repository PR in forked repository: <!-- ENTER URL HERE --> <!-- After opening this PR, the build in apache/pulsar will fail and instructions will be provided for opening a PR in the PR author's forked repository. apache/pulsar pull requests should be first tested in your own fork since the apache/pulsar CI based on GitHub Actions has constrained resources and quota. GitHub Actions provides separate quota for pull requests that are executed in a forked repository. The tests will be run in the forked repository until all PR review comments have been handled, the tests pass and the PR is approved by a reviewer. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
