liangyepianzhou commented on code in PR #21495:
URL: https://github.com/apache/pulsar/pull/21495#discussion_r1379682660


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java:
##########
@@ -206,6 +206,12 @@ private void 
receiveSubscriptionUpdated(ReplicatedSubscriptionsUpdate update) {
     private void startNewSnapshot() {

Review Comment:
   I am trying to use this way for the first time.
   But If we do not create `ReplicatedSubscriptionsController ` when turning 
off `replication`, the `ReplicatedSubscriptionsController` cannot be created 
when enabling replication at the namespace level.
   ```
   bin/pulsar-admin namespaces set-clusters my-tenant/my-namespace \
   --clusters us-west,us-east,us-cent
   ``` 
   
   Do you have any idea you do this? Adding a new API to start 
`ReplicatedSubscriptionsController` for all topics in the namespace in all the 
brokers maybe can do that, but that adds too much complexity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to