codelipenghui commented on code in PR #21406:
URL: https://github.com/apache/pulsar/pull/21406#discussion_r1381754682
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBuffer.java:
##########
@@ -188,14 +188,14 @@ public interface TransactionBuffer {
TransactionBufferStats getStats(boolean lowWaterMarks);
/**
- * Wait TransactionBuffer Recovers completely.
- * Take snapshot after TB Recovers completely.
+ * Wait TransactionBuffer recovers completely.
* @param isTxn
- * @return a future which has completely if isTxn = false. Or a future
return by takeSnapshot.
+ * @return a future whether the transaction buffer recover completely.
*/
- CompletableFuture<Void> checkIfTBRecoverCompletely(boolean isTxn);
-
-
+ @Deprecated
+ default CompletableFuture<Void> checkIfTBRecoverCompletely(boolean isTxn) {
+ return CompletableFuture.completedFuture(null);
+ }
Review Comment:
> But I have a concern about this, we provide TransactionBufferProvider for
the users to implement a custom version based on the TransactionBuffer
interface. Will this change impact these users?
It's a beta interface, which means it is not stable. If the method doesn't
make sense to the interface, then we can remove it.
https://github.com/apache/pulsar/blob/99e6aebb88c8ea82c8b8d65261ce71f0ab8d36d8/pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/buffer/TransactionBuffer.java#L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
