mattisonchao commented on code in PR #21540:
URL: https://github.com/apache/pulsar/pull/21540#discussion_r1385792640
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java:
##########
@@ -1724,7 +1724,7 @@ public void openLedgerComplete(ManagedLedger ledger,
Object ctx) {
});
persistentTopic.stopReplProducers()
.whenCompleteAsync((v,
exception) -> {
-
topics.remove(topic, topicFuture);
+
persistentTopic.close();
Review Comment:
Aha, I wanted to fix it there before.
If you chose the topic closely. You don't need the following codes. Because
topic#close already does it.
```
persistentTopic.getTransactionBuffer()
.closeAsync()
.exceptionally(t -> {
log.error("[{}]
Close transactionBuffer failed", topic, t);
return null;
});
persistentTopic.stopReplProducers()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
