RobertIndie commented on code in PR #21507:
URL: https://github.com/apache/pulsar/pull/21507#discussion_r1387411745
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
Review Comment:
We need to state the motivation for adding the producer name. Is it only for
debugging purposes?
##########
pip/pip-316.md:
##########
@@ -0,0 +1,83 @@
+
+# PIP-316: Create a producerName field for DeadLetterPolicy
+
+
+# Motivation
+
+Add producerName for dead letter producer, easier to locate problems.
+
+
+# Goals
+
+## In Scope
+
+Add a new field `producerName` in
`org.apache.pulsar.client.api.DeadLetterPolicy` class.
+
+
+## Out of Scope
+None.
+
+# High Level Design
+
+If `producerName` is not empty, use `producerName` as the name of the dead
letter producer.
Review Comment:
Could we use something like `${topic-name}-${subscription-name}-DLQ` as the
producer name without introducing the `producerName` to the DLQ policy?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
