equanz commented on code in PR #21532:
URL: https://github.com/apache/pulsar/pull/21532#discussion_r1389036186
##########
pom.xml:
##########
@@ -85,7 +85,7 @@ flexible messaging model and an intuitive client
API.</description>
<pulsar.client.python.version>3.2.0</pulsar.client.python.version>
<!--config keys to configure test selection -->
-
<include>**/Test*.java,**/*Test.java,**/*Tests.java,**/*TestCase.java</include>
+ <include>*</include>
Review Comment:
I found omitted tests by following commands.
```
$ find . ! -name '*Test*' -name "*.java" -exec grep -H "@Test" {} \;
$ find . -regextype posix-basic -regex '.*/[^/]\+Test[^/]\+\.java$' ! -regex
'.*Test\(s\)\?.java$' -exec grep -H "@Test" {} \;
```
exceptions:
* abstract classes
* org.apache.pulsar.metadata.MetadataBenchmark
- It doesn't have to run in unit tests.
* backward compatibility tests
- e.g. `SmokeTest2_5.java`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
