liangyepianzhou opened a new issue, #21580:
URL: https://github.com/apache/pulsar/issues/21580

   ### Search before asking
   
   - [X] I searched in the [issues](https://github.com/apache/pulsar/issues) 
and found nothing similar.
   
   
   ### Motivation
   
   Now we have 8 methods to create an ack command. We should consider to check 
which one is redundant.
   <img width="638" alt="image" 
src="https://github.com/apache/pulsar/assets/12592133/a833955f-e1e5-4df9-bb7e-f9cb78917239";>
   See more details at https://github.com/apache/pulsar/pull/21419.
   
   ### Solution
   
   Only keep `public static ByteBuf newMultiMessageAck(long consumerId, TxnID 
txnID,
               List<Triple<Long, Long, ConcurrentBitSetRecyclable>> entries, 
long requestID) ` and mark other methods as deprecated.
   
   ### Alternatives
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to